Request for Review (xs) - 8151845: Comment in globals.hpp for MetaspaceSize is incorrect.

kirk at kodewerk.com kirk at kodewerk.com
Tue Mar 15 17:59:08 UTC 2016


Hi Jon,

I very much like what you have written.

Kind regards,
Kirk

> On Mar 15, 2016, at 5:56 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
> 
> https://bugs.openjdk.java.net/browse/JDK-8151845
> 
> Change the description for MetaspaceSize in globals.hpp thus
> 
> -          "Initial size of Metaspaces (in bytes)")                          \
> +          "Initial threshold (in bytes) at which a garbage collection "     \
> +          "is done to reduce Metaspace usage")                              \
> 
> Garbage collections will be done specifically to recover metadata
> (the GC finds dead classloaders and identifies metadata associated
> with the classloaders that is no longer used).  Triggering a GC for
> metadata recovery is done if the amount of metadata in use exceeds
> a threshold that is dynamically adjusted (threshold is raised or lowered
> depending on the amount of Metaspace made available for new metadata
> allocations).  MetaspaceSize is the initial threshold.
> 
> http://cr.openjdk.java.net/~jmasa/8141845/webrev.00/
> 
> I am very open to suggestions for a better description.
> 
> My apologies to Yasumasa Suenaga for not settling this issue
> when he raised it almost 2 years ago.
> 
> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2014-April/009916.html
> 
> Jon
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20160315/35cf9ecf/signature.asc>


More information about the hotspot-gc-dev mailing list