Request for Review (s) - 8149343: assert(rp->num_q() == no_of_gc_workers) failed: sanity

Kim Barrett kim.barrett at oracle.com
Fri Mar 18 22:16:05 UTC 2016


> On Mar 18, 2016, at 2:39 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
> 
> New versions of the webrev's
> 
> Changes from 01
> http://cr.openjdk.java.net/~jmasa/8149343/webrev_delta.01_02/
> 
> Complete
> http://cr.openjdk.java.net/~jmasa/8149343/webrev.02/
> 
> This wrong indentation does not show as changed lines
> in the webrev but if you look for them, they are fixed in 02.

------------------------------------------------------------------------------ 
src/share/vm/gc/shared/referenceProcessor.cpp
 696   for (uint i = active_length; i < _max_num_q; i++)
 697     assert(ref_lists[i].length() == 0, "%u unexpected References in %u",
 698            ref_lists[i].length(), i); 

Missing braces around for-loop body.

Also, though I expect the compiler will eliminate the empty loop
entirely in release mode, for readability I'd prefer the whole
for-loop be surrounded by #ifdef ASSERT ... #endif.

------------------------------------------------------------------------------

I don't need a new webrev for those.

Otherwise looks good.



More information about the hotspot-gc-dev mailing list