RFR: (S): 8142935: Adding old gen regions does not consider available free space

Kim Barrett kim.barrett at oracle.com
Sun Mar 20 20:40:45 UTC 2016


> On Mar 19, 2016, at 9:10 AM, Tom Benson <tom.benson at oracle.com> wrote:
> 
> Hi Derek,
> Thanks for taking a look.    I see that the link under the webrev text was bad due to cut/paste, so here's a good one for any new readers:
>   Webrev:  http://cr.openjdk.java.net/~tbenson/8142935/webrev/

------------------------------------------------------------------------------ 
src/share/vm/gc/g1/g1CollectionSet.cpp
 418     } else if ((_bytes_live_before + hr->live_bytes()) > estimated_available_bytes) {
 419       log_debug(gc, ergo, cset)("Finish adding old regions to CSet (reached estimated free space limit)");

This logging seems like it belongs with the code that led to the loop
exit, here:

 374       if ((_bytes_live_before + hr->live_bytes()) > estimated_available_bytes) {
 375         break;
 376       }

That is, put the logging statement before the break at line 375.

------------------------------------------------------------------------------

Other than that, looks good.



More information about the hotspot-gc-dev mailing list