RFR: (S): 8142935: Adding old gen regions does not consider available free space

Tom Benson tom.benson at oracle.com
Mon Mar 21 20:29:43 UTC 2016


Thanks Kim and Derek.
Tom

On 3/21/2016 2:05 PM, Derek White wrote:
> Yep, looks good.
>
> On 3/21/16 1:51 PM, Kim Barrett wrote:
>>> On Mar 21, 2016, at 11:38 AM, Tom Benson <tom.benson at oracle.com> wrote:
>>>
>>> Hi Kim,
>>> Thanks for the review.
>>>
>>> On 3/20/2016 4:40 PM, Kim Barrett wrote:
>>>> ------------------------------------------------------------------------------ 
>>>>
>>>> src/share/vm/gc/g1/g1CollectionSet.cpp
>>>>   418     } else if ((_bytes_live_before + hr->live_bytes()) > 
>>>> estimated_available_bytes) {
>>>>   419       log_debug(gc, ergo, cset)("Finish adding old regions to 
>>>> CSet (reached estimated free space limit)");
>>>>
>>>> This logging seems like it belongs with the code that led to the loop
>>>> exit, here:
>>>>
>>>>   374       if ((_bytes_live_before + hr->live_bytes()) > 
>>>> estimated_available_bytes) {
>>>>   375         break;
>>>>   376       }
>>>>
>>>> That is, put the logging statement before the break at line 375.
>>> Good point.  Incremental/updated webrevs:
>>>   http://cr.openjdk.java.net/~tbenson/8142935/webrev.1.vs.0
>>>   http://cr.openjdk.java.net/~tbenson/8142935/webrev.1/
>> Looks good.
>>
>



More information about the hotspot-gc-dev mailing list