RFR(s): 8152160: SIGFPE in CompactibleFreeListSpaceLAB::compute_desired_plab_size

sangheon sangheon.kim at oracle.com
Wed Mar 23 04:02:19 UTC 2016


Hi Per,

Thanks for the review.

Sangheon


On 03/22/2016 11:38 AM, Per Liden wrote:
>
>> On 22 Mar 2016, at 18:19, sangheon <sangheon.kim at oracle.com 
>> <mailto:sangheon.kim at oracle.com>> wrote:
>>
>> Hi Per,
>>
>> Thank you for reviewing this issue.
>>
>> On 03/22/2016 08:59 AM, Per Liden wrote:
>>> Hi Sangheon,
>>>
>>> On 2016-03-22 03:12, sangheon wrote:
>>>> Hi all,
>>>>
>>>> Could I have a couple of reviews for this change?
>>>>
>>>> With large value of CMSOldPLABNumRefills, SIGFPE would happen at
>>>> CompactibleFreeListSpaceLAB::compute_desired_plab_size() because 
>>>> related
>>>> routine would be zero by an overflow.
>>>>
>>>> Type-casting to 'double' before the problematic division will resolve
>>>> the problem.
>>>
>>> Casting to double doesn't quite seem like the right thing to do 
>>> here. Can't this be rephrased to avoid the overflow completely, 
>>> something like:
>>>
>>> _global_num_blocks[i] / _global_num_workers[i] / CMSOldPLABNumRefills
>> You are right!
>> I like this much more.
>>
>> Webrev:http://cr.openjdk.java.net/~sangheki/8152160/webrev.01 
>> <http://cr.openjdk.java.net/%7Esangheki/8152160/webrev.01>
>>
>
> Looks good.
>
> Per
>
>
>> Sangheon
>>
>>>
>>> cheers,
>>> Per
>>>
>>>>
>>>> CR:https://bugs.openjdk.java.net/browse/JDK-8152160
>>>> Webrev:http://cr.openjdk.java.net/~sangheki/8152160/webrev.00 
>>>> <http://cr.openjdk.java.net/%7Esangheki/8152160/webrev.00>
>>>> Testing: JPRT, TestOptionsWithRanges.java via RBT and manual test as CR
>>>> description.
>>>>
>>>> Thanks,
>>>> Sangheon
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20160322/090e9179/attachment-0001.html>


More information about the hotspot-gc-dev mailing list