RFR: JDK-8153186: Convert TraceGCTaskThread to use unified logging
bengt.rutisson at oracle.com
Thu Mar 31 13:34:55 UTC 2016
On 2016-03-31 15:14, Thomas Schatzl wrote:
> Hi Bengt,
> On Thu, 2016-03-31 at 14:59 +0200, Bengt Rutisson wrote:
>> Hi Thomas,
>> Thanks for looking at this!
>> On 2016-03-31 14:50, Thomas Schatzl wrote:
>>> On Thu, 2016-03-31 at 14:23 +0200, Bengt Rutisson wrote:
>>>> Hi everyone,
>>>> Could I have a couple of reviews for this change?
>>>> The logging guarded by TraceGCTaskThread should be converted to
>>>> unified logging framework.
>>> - these log messages seem to be gc specific, so maybe add the gc
>> This logging is all done at initilization, before we start a GC so I
>> don't think there is a point in adding the GC id decoration.
>>> - this change simply removes the flag from the available
>>> Shouldn't it be added to the table we have that translates old
>>> flags to
>>> new logging somewhere? (I do not have an opinion about this, just
>> There are some internal table for such conversion. I can look in to
>> adding it there. For the public documentation we have selected a
>> of all flags to document. I don't think this flag is used widely
>> to qualify for that list.
> okay. Ship it.
Great! :) Thanks!
More information about the hotspot-gc-dev