RFR: JDK-8153187: Convert TraceWorkGang to use unified logging

Bengt Rutisson bengt.rutisson at oracle.com
Thu Mar 31 13:38:18 UTC 2016


Hi Thomas,

On 2016-03-31 15:23, Thomas Schatzl wrote:
> Hi Bengt,
>
> On Thu, 2016-03-31 at 14:30 +0200, Bengt Rutisson wrote:
>> Hi everyone,
>>
>> Could I have a couple of reviews for this change?
>>
>> http://cr.openjdk.java.net/~brutisso/8153187/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8153187
>>
>> The logging guarded by TraceWorkGang should be converted to use the
>> unified logging framework.
>>
>> The logging now has this format:
>>
> [...]
>
> - workgroup.cpp: if you care, please update the copyright.

Fixed.

>
> - workgroup.cpp:43:
>    43   log_develop_trace(gc, workgang)("Constructing work gang %s with
> %d threads", name(), total_workers());
>
>
> %d should be %u (pre-existing).

Nice catch! Fixed.

>
> I do not need a re-review for these changes.

Ok. Thanks for the review!

Bengt

>
> Thanks,
>    Thomas
>



More information about the hotspot-gc-dev mailing list