RFR (XXS): 8153193: Missing includes in gc/g1/heapRegionBounds.hpp

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Thu Mar 31 13:42:49 UTC 2016


Looks good!
/Jesper

Den 31/3/16 kl. 15:10, skrev Thomas Schatzl:
> Hi all,
>
>    can I have quick reviews for this change that adds a missing include
> to the file in question?
>
> The HeapRegionBounds class inherits from AllStatic, which is in
> memory/allocation.hpp that is not included. Some future changes break
> because of this oversight.
>
> For current sources there is no difference.
>
> Note that strictly we should probably also include stddef.h for size_t,
> but looking through other sources, this is (almost) never done. So I
> refrained from doing so here too.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8153193
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8153193/webrev/
> Testing:
> local testing
>
> Thanks,
>    Thomas
>


More information about the hotspot-gc-dev mailing list