RFR (XS) JDK-8164482,[REDO] G1 does not implement millis_since_last_gc which is needed by RMI GC

Thomas Schatzl thomas.schatzl at oracle.com
Mon Sep 5 11:25:36 UTC 2016


Hi,

On Mon, 2016-09-05 at 13:17 +0200, Thomas Schatzl wrote:
> Hi again,
> 
> On Mon, 2016-09-05 at 13:13 +0200, Thomas Schatzl wrote:
> > 
> > Hi,
> > 
> > On Fri, 2016-09-02 at 09:40 -0400, Joseph Provino wrote:
> > > 
> > > 
> > > Please review this small change.
> > > JDK-8164482 [REDO] G1 does not implement millis_since_last_gc
> > > which
> > > is needed by RMI GC
> > > webrev:  http://cr.openjdk.java.net/~jprovino/8164482/webrev.00
> >   looks good.
>   after having another look, I do not think the change is
> good: millis_since_last_gc() tracks the time since any last gc
> (probably collection pause), so the last gc time needs to be updated
> at the end of every gc, not only full gcs.
> 
> The member and the getter name should also reflect this.

  also, what kind of testing did this change go through?

Please always mention this during the first review request email.

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list