RFR (XS) JDK-8164482,[REDO] G1 does not implement millis_since_last_gc which is needed by RMI GC
joseph.provino at oracle.com
Thu Sep 8 13:54:19 UTC 2016
Latest Webrev: http://cr.openjdk.java.net/~jprovino/8164482/webrev.01
1. JDK-8164482 <https://bugs.openjdk.java.net/browse/JDK-8164482>[REDO]
G1 does not implement millis_since_last_gc which is needed by RMI GC
Tests: JPRT. Also, I put in a log message for testing. It calls
millis_since_last_gc() before each collection. This will be removed
before pushing. The messages printed show millis since last gc always
>= 0 and the warning message is never printed.
On 9/5/2016 7:25 AM, Thomas Schatzl wrote:
> On Mon, 2016-09-05 at 13:17 +0200, Thomas Schatzl wrote:
>> Hi again,
>> On Mon, 2016-09-05 at 13:13 +0200, Thomas Schatzl wrote:
>>> On Fri, 2016-09-02 at 09:40 -0400, Joseph Provino wrote:
>>>> Please review this small change.
>>>> JDK-8164482 [REDO] G1 does not implement millis_since_last_gc
>>>> is needed by RMI GC
>>>> webrev: http://cr.openjdk.java.net/~jprovino/8164482/webrev.00
>>> looks good.
>> after having another look, I do not think the change is
>> good: millis_since_last_gc() tracks the time since any last gc
>> (probably collection pause), so the last gc time needs to be updated
>> at the end of every gc, not only full gcs.
>> The member and the getter name should also reflect this.
> also, what kind of testing did this change go through?
> Please always mention this during the first review request email.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-gc-dev