RFR(S): 8159818: Convert IHOP_test to GTest

Thomas Schatzl thomas.schatzl at oracle.com
Tue Sep 27 07:53:52 UTC 2016


Hi,

On Mon, 2016-09-26 at 17:55 +0300, Kirill Zhaldybin wrote:
> Thomas,
> 
> Thank you for reviewing the fix!
> 
> Here are a new WebRev: 
> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8159818/webrev.01/
> 
> Could you please let me know your opinion?
> 
> Changes:
> 1. g1IHOPControl.hpp copyright updated
> 2. static void test_update parameters list reformatted.
> 3. Comment "Test could be only run with G1" changed to "Test requires
> G1"
> 4. Some reviewers are pretty strict about 80 symbols. Could you
> please let me know if I need to change limit for the line lengths?

  no, keep it. It's not that much of an issue.

Looks good.

Thomas



More information about the hotspot-gc-dev mailing list