RFR(S): 8159818: Convert IHOP_test to GTest
kirill.zhaldybin at oracle.com
Tue Sep 27 07:57:52 UTC 2016
Thank you for review!
On 09/27/2016 10:53 AM, Thomas Schatzl wrote:
> On Mon, 2016-09-26 at 17:55 +0300, Kirill Zhaldybin wrote:
>> Thank you for reviewing the fix!
>> Here are a new WebRev:
>> Could you please let me know your opinion?
>> 1. g1IHOPControl.hpp copyright updated
>> 2. static void test_update parameters list reformatted.
>> 3. Comment "Test could be only run with G1" changed to "Test requires
>> 4. Some reviewers are pretty strict about 80 symbols. Could you
>> please let me know if I need to change limit for the line lengths?
> no, keep it. It's not that much of an issue.
> Looks good.
More information about the hotspot-gc-dev