[9] RFR (S): 8177963: Parallel GC fails fast when per-thread task log overflows

Srinivas Ramakrishna ysr1729 at gmail.com
Wed Apr 5 23:38:12 UTC 2017


Re webrev.1: Good, but I think you shouldn't print the overflow message
each time overflow occurs while writing, but only at the end when the
timestamp entries are printed. That should suffice to let user know an
overflow occurred and how big a size they may need (that shd be part of the
overflow message).

-- ramki

On Wed, Apr 5, 2017 at 11:16 AM, Thomas Schatzl <thomas.schatzl at oracle.com>
wrote:

> Hi Sangheon,
>
> On Wed, 2017-04-05 at 10:47 -0700, sangheon wrote:
> > Hi Thomas,
> >
> [...]
> > > New webrevs at:
> > > http://cr.openjdk.java.net/~tschatzl/8177963/webrev.0_to_1 (diff)
> > > http://cr.openjdk.java.net/~tschatzl/8177963/webrev.1 (full)
> > webrev.1 seems good to me.
>
>   thanks for your review.
>
> Thomas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20170405/abc37eab/attachment-0001.html>


More information about the hotspot-gc-dev mailing list