RFR: 8166191: Missing spaces in log message

Thomas Schatzl thomas.schatzl at oracle.com
Tue Apr 11 14:02:18 UTC 2017


Hi Chihiro,

On Tue, 2017-04-11 at 03:04 +0900, chihiro ito wrote:
> Hi all,
> 
> Could I have a reviews for this fix, please? This patch add spaces 
> following each ":" like a JDK 8 log in log message.
> 
> Log message that ran JDK 9 with -Xlog:gc+ergo+heap=debug option is 
> following.
> [0.019s][debug][gc,ergo,heap] Expand the heap. requested expansion 
> amount: 10485760B expansion amount: 10485760B
> 
> Log message that ran JDK 8 with -XX:+PrintAdaptiveSizePolicy option
> is following.
> 0.124: [G1Ergonomics (Heap Sizing) expand the heap, requested
> expansion amount: 10485760 bytes, attempted expansion amount:
> 10485760 bytes]
> 
> Bug:
> Missing spaces in log message
> https://bugs.openjdk.java.net/browse/JDK-8166191

I also noticed that just a few days ago. Thanks for fixing this :)

I created a webrev from your diff at

http://cr.openjdk.java.net/~tschatzl/8166191/webrev/

Looks good. I can sponsor.

Passes jprt.

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list