RFR: 8166191: Missing spaces in log message

chihiro ito chihiro.ito at oracle.com
Tue Apr 11 16:23:20 UTC 2017


Hi Thomas,

Thanks you for reviewing diff :)

Chihiro

On 2017/04/11 23:02, Thomas Schatzl wrote:
> Hi Chihiro,
>
> On Tue, 2017-04-11 at 03:04 +0900, chihiro ito wrote:
>> Hi all,
>>
>> Could I have a reviews for this fix, please? This patch add spaces
>> following each ":" like a JDK 8 log in log message.
>>
>> Log message that ran JDK 9 with -Xlog:gc+ergo+heap=debug option is
>> following.
>> [0.019s][debug][gc,ergo,heap] Expand the heap. requested expansion
>> amount: 10485760B expansion amount: 10485760B
>>
>> Log message that ran JDK 8 with -XX:+PrintAdaptiveSizePolicy option
>> is following.
>> 0.124: [G1Ergonomics (Heap Sizing) expand the heap, requested
>> expansion amount: 10485760 bytes, attempted expansion amount:
>> 10485760 bytes]
>>
>> Bug:
>> Missing spaces in log message
>> https://bugs.openjdk.java.net/browse/JDK-8166191
> I also noticed that just a few days ago. Thanks for fixing this :)
>
> I created a webrev from your diff at
>
> http://cr.openjdk.java.net/~tschatzl/8166191/webrev/
>
> Looks good. I can sponsor.
>
> Passes jprt.
>
> Thanks,
>    Thomas
>

-- 

Chihiro Ito | Principal Consultant | +81.90.6148.8815
Oracle <http://www.oracle.com> Consultant
ORACLE Japan | Akasaka Center Bldg. | Motoakasaka 1-3-13 | 1070051 
Minato-ku, Tokyo, JAPAN

Oracle is committed to developing practices and products that help 
protect the environment <http://www.oracle.com/commitment>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20170412/d16be3a5/attachment-0001.html>


More information about the hotspot-gc-dev mailing list