RFR: 8178836: Improve PtrQueue index abstraction

Aleksey Shipilev ashipile at redhat.com
Wed Apr 19 19:20:20 UTC 2017


On 04/19/2017 09:05 PM, Kim Barrett wrote:
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8178836/hotspot.00/

Looks nice.

Minor nits:

*) On first scan, "limit" reads as the loop variable, because it is the only
initialization in init block. Move it out?

 161   for (size_t limit = buffer_size(); i < limit; ++i) {

*) Is there a Unified Logging tag for these?

 185   tty->print_cr("  SATB BUFFER [%s] buf: ...

Thanks,
-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20170419/b9070af2/signature.asc>


More information about the hotspot-gc-dev mailing list