RFR: 8178836: Improve PtrQueue index abstraction

Kim Barrett kim.barrett at oracle.com
Fri Apr 21 23:00:05 UTC 2017


> On Apr 19, 2017, at 3:20 PM, Aleksey Shipilev <ashipile at redhat.com> wrote:
> 
> On 04/19/2017 09:05 PM, Kim Barrett wrote:
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8178836/hotspot.00/
> 
> Looks nice.

Thanks.

> Minor nits:
> 
> *) On first scan, "limit" reads as the loop variable, because it is the only
> initialization in init block. Move it out?
> 
> 161   for (size_t limit = buffer_size(); i < limit; ++i) {

OK.

> *) Is there a Unified Logging tag for these?
> 
> 185   tty->print_cr("  SATB BUFFER [%s] buf: …

This is a print function, for calling from the debugger, and not for logging.



More information about the hotspot-gc-dev mailing list