RFR: JDK-8179259: Clean up BarrierSet

Roman Kennke rkennke at redhat.com
Wed Apr 26 20:18:03 UTC 2017


Am 25.04.2017 um 12:55 schrieb Roman Kennke:
> The BarrierSet class has lots of has_* and needs_* methods, none of
> which is used anywhere, except (some) in asserts (which is bogus too),
> and in one instance in a stub generator (which will be refactored to use
> the same paradigm as elsewhere). Those methods clutter the BarrierSet
> interface and need to be implemented in subclasses for no good reason.
> 
> http://cr.openjdk.java.net/~rkennke/JDK-8163329/webrev.00/
> 
> Tests: hotspot_gc, specjvm
> 
> I also filed a small number of minor GC-interface related
> enhancement/refactoring bugs, all relatively isolated, all listed in the
> GC interface JEP. Will propose them soon, unless somebody stops me ;-)
> 
> Oh, and maybe move the GC interface JEP to 'candidate' so that it gets a
> valid number?
> 
> https://bugs.openjdk.java.net/browse/JDK-8163329

I now realize that Erik Österlund's work does cover this, and much much
more, and have already withdrawn the related bugs, and do also withdraw
this RFR. I'll focus my GC interface work on non-BarrierSet related
issues and areas where I can help fill in the BarrierSet (aarch64,
finding barrier sites for primitive loads/stores etc).

Roman


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20170426/6416e28e/signature.asc>


More information about the hotspot-gc-dev mailing list