RFR: 8133805: Remove the bot_updates parameter from G1Allocator's allocation methods

Stefan Johansson stefan.johansson at oracle.com
Tue Dec 12 16:08:29 UTC 2017



On 2017-12-12 13:07, Thomas Schatzl wrote:
> Hi,
>
> On Mon, 2017-12-11 at 15:32 +0100, Leo Korinth wrote:
>> Hi,
>>
>> The bot_updates parameter is removed so that the code is easier to
>> read.
>> The original idea behind the parameter is that the compiler will be
>> able to remove a branch instruction (in certain cases) because the
>> value will be known at compile time. As several classes inherits from
>> the base G1AllocRegion the member variable _bot_updates is not known
>> to the base class though it is always set to the same value in each
>> of the separate sub classes.
>>
>> I made the constructor G1GCAllocRegion protected (from public) to
>> better show that that each *AllocRegion class with public constructor
>> will have a fixed _bot_updates value (per class).
>>
> [...]
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8133805
>>
>> Webrev:
>> http://cr.openjdk.java.net/~lkorinth/8133805/00/
>>
>> Testing:
>> mach5 hs-tier1,hs-tier2
> - in g1AllocRegion.hpp, please fix the indentation of the parameters
> for G1AllocRegion::allocate() and par_allocate().
>
> looks good otherwise.
I agree, align the parameters and this is good to go.

Thanks,
Stefan
>
> Thanks,
>    Thomas
>



More information about the hotspot-gc-dev mailing list