RFR(S): 8173013: JVMTI tagged object access needs G1 pre-barrier

sangheon sangheon.kim at oracle.com
Mon Feb 6 06:10:51 UTC 2017


Hi Kim and Thomas,

Here's webrev.2 with Thomas' comment version.
http://cr.openjdk.java.net/~sangheki/8173013/webrev.2

--------------------

1538 #if INCLUDE_ALL_GCS
1539 if (UseG1GC) {
1540 // The reference in this tag map could be the only (implicitly weak)
1541 // reference to that object. If we hand it out, we need to keep it 
live wrt
1542 // SATB marking similar to other j.l.ref.Reference referents.
1543 G1SATBCardTableModRefBS::enqueue(o);
1544 }
1545 #endif

--------------------

Thanks,
Sangheon


On 02/03/2017 01:10 PM, sangheon wrote:
> Hi Kim,
>
> On 02/03/2017 01:05 PM, Kim Barrett wrote:
>>> On Feb 3, 2017, at 1:41 PM, sangheon <sangheon.kim at oracle.com> wrote:
>>>> "The reference in this tag map could be the only (implicitly weak)
>>>> reference to that object. If we hand it out we need to keep it live 
>>>> wrt
>>>> SATB marking similar to other j.l.ref.Reference referents."
>>> I like this comment.
>>> If other reviewers don't have better suggestion, I will upload the 
>>> revised patch with this.
>> Looks good with something like Thomas's improved comment.
>>
> Thanks for the review and all the discussion for this CR.
> And Thomas' comment is the candidate for now.
>
> Sangheon
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20170205/0c744b48/attachment.html>


More information about the hotspot-gc-dev mailing list