10 RFR: 8175221: Cleanup DirtyCardQueueSet::concatenate_log

Thomas Schatzl thomas.schatzl at oracle.com
Wed Feb 22 09:27:28 UTC 2017


Hi,

On Tue, 2017-02-21 at 10:35 -0500, Kim Barrett wrote:
> > 
> > On Feb 21, 2017, at 7:01 AM, Thomas Schatzl <thomas.schatzl at oracle.
> > com> wrote:
> > 
> > Hi Kim,
> > 
> > On Sun, 2017-02-19 at 16:38 -0500, Kim Barrett wrote:
> > > 
> > > [...]
> > > performing a flush when destroying the shared queue for a set was
> > > problematic.  However, JDK-8048949 changed things so that only
> > > the
> > > DirtyCardQueue destructor called flush, and only if the queue is
> > > non-permanent.  So the permanent check in flush is no longer
> > > needed,
> > > and removing it makes it suitable for use by concatenate_log.
> > > 
> > > CR:
> > > https://bugs.openjdk.java.net/browse/JDK-8175221
> > > 
> > > Webrev:
> > > http://cr.openjdk.java.net/~kbarrett/8175221/hotspot.00/
> > > 
> >   looks good to me.
> Thanks.
> 
> > 
> > Given your description, and some short look through
> > the callers of the code, is it useful to assert that flush is not
> > called on permanent ptrqueues?
> No. The new concatenate_log use of flush violates that.
> 

  I dug into the code some more (haven't looked into it for some time),
did some experiments, and I think the changes is still good.

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list