RFR: 8173764: Assert in G1 BOT is wrong

Kim Barrett kim.barrett at oracle.com
Wed Feb 22 20:40:52 UTC 2017


> On Feb 22, 2017, at 8:47 AM, Stefan Johansson <stefan.johansson at oracle.com> wrote:
> […]
> Updated webrevs:
> Full: http://cr.openjdk.java.net/~sjohanss/8173764/hotspot.01/
> Inc:  http://cr.openjdk.java.net/~sjohanss/8173764/hotspot.00-01/

------------------------------------------------------------------------------
src/share/vm/gc/g1/g1BlockOffsetTable.cpp
 369 #ifndef PRODUCT
 370 void G1BlockOffsetTablePart::set_object_can_span(bool can_span) {
 371   _object_can_span = can_span;
 372 }

This should be #ifdef ASSERT, and the declaration should be
NOT_DEBUG_RETURN.  As written, an "optimize" build will fail.

------------------------------------------------------------------------------





More information about the hotspot-gc-dev mailing list