RFR: 8173764: Assert in G1 BOT is wrong

Kim Barrett kim.barrett at oracle.com
Thu Feb 23 13:46:14 UTC 2017


> On Feb 23, 2017, at 4:30 AM, Stefan Johansson <stefan.johansson at oracle.com> wrote:
> 
> Thanks Kim,
> 
> On 2017-02-22 21:40, Kim Barrett wrote:
>>> On Feb 22, 2017, at 8:47 AM, Stefan Johansson <stefan.johansson at oracle.com> wrote:
>>> […]
>>> Updated webrevs:
>>> Full: http://cr.openjdk.java.net/~sjohanss/8173764/hotspot.01/
>>> Inc:  http://cr.openjdk.java.net/~sjohanss/8173764/hotspot.00-01/
>> ------------------------------------------------------------------------------
>> src/share/vm/gc/g1/g1BlockOffsetTable.cpp
>>  369 #ifndef PRODUCT
>>  370 void G1BlockOffsetTablePart::set_object_can_span(bool can_span) {
>>  371   _object_can_span = can_span;
>>  372 }
>> 
>> This should be #ifdef ASSERT, and the declaration should be
>> NOT_DEBUG_RETURN.  As written, an "optimize" build will fail.
>> 
>> ------------------------------------------------------------------------------
>> 
> Nice catch! I've heard that people want to remove optimized builds, after this, add me to that list :)
> 
> I changed it as you suggested and now it builds when using optimized:
> Full: http://cr.openjdk.java.net/~sjohanss/8173764/hotspot.02/
> Inc: http://cr.openjdk.java.net/~sjohanss/8173764/hotspot.01-02/
> 
> Thanks,
> Stefan

looks good



More information about the hotspot-gc-dev mailing list