RFR: 8173764: Assert in G1 BOT is wrong

Stefan Johansson stefan.johansson at oracle.com
Fri Feb 24 09:39:38 UTC 2017



On 2017-02-23 10:38, Thomas Schatzl wrote:
> Hi Stefan,
>
> On Thu, 2017-02-23 at 10:30 +0100, Stefan Johansson wrote:
>> Thanks Kim,
>>
>> On 2017-02-22 21:40, Kim Barrett wrote:
> [...]
>>> This should be #ifdef ASSERT, and the declaration should be
>>> NOT_DEBUG_RETURN.  As written, an "optimize" build will fail.
>>>
>>> -----------------------------------------------------------------
>>> -------------
>>>
>> Nice catch! I've heard that people want to remove optimized builds,
>> after this, add me to that list :)
>>
>> I changed it as you suggested and now it builds when using optimized:
>> Full: http://cr.openjdk.java.net/~sjohanss/8173764/hotspot.02/
>> Inc: http://cr.openjdk.java.net/~sjohanss/8173764/hotspot.01-02/
> I would prefer if the assert text also talked
> about G1BlockOffsetTablePart instead of regions, but I can see that it
> might be more clear that way.
>
> If you change this, I do not need to see a re-review - or just ignore
> this comment.
>
> Looks good. Ship it.
Thanks for the review, I'll leave it as.

Stefan
> Thomas
>



More information about the hotspot-gc-dev mailing list