10 RFR: 8169517: WhiteBox should provide concurrent GC phase control

Aleksey Shipilev shade at redhat.com
Fri Mar 3 10:16:30 UTC 2017


On 03/03/2017 10:59 AM, Kim Barrett wrote:
> Looking for reviewers.
> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8169517/hs.00/
>> http://cr.openjdk.java.net/~kbarrett/8169517/hotspot.00/

I can see how that can be helpful. We will probably try to adapt this to
Shenandoah too, once we pull this into Shenandoah forest.

Comments:

 *) Purely string-based interface makes me itchy. If we follow this route,
shouldn't the collector report what phases it supports? Otherwise, testers would
have to end up polling the phases looking for "false", and before that, looking
into the GC code to figure out phase names. Given that proposed G1 code already
builds const char* const names[], could it report it via Whitebox too?

Otherwise looks good. Time will tell if that was a good idea :)

Thanks,
-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20170303/b1a51976/signature.asc>


More information about the hotspot-gc-dev mailing list