Request for review JDK-8165674 - G1CMMarkStack::out_of_memory possibly redundant

Kim Barrett kim.barrett at oracle.com
Tue Mar 7 20:05:31 UTC 2017


> On Mar 7, 2017, at 2:26 PM, Alexander Harlap <alexander.harlap at oracle.com> wrote:
> 
> Happy to get  review.
> 
> Changed to use
> 
> G1ConcurrentMark::_has_overflown

I like this better.  I'd intended to make comments similar promises but he got there first.

> Revised change is here:
> 
> http://cr.openjdk.java.net/~aharlap/8165674/webrev.02/

One very minor and nit:

src/share/vm/gc/g1/g1ConcurrentMark.cpp
1746             "Mark stack should be empty (unless it is out of memory)");

The assert message should refer to “overflow" rather than "out of memory”

Looks good otherwise.
I don't need a new webrev for a change there.



More information about the hotspot-gc-dev mailing list