RFR(XS): 8176403: [TESTBUG] gc/arguments/TestSmallInitialHeapWithLargePageAndNUMA is referencing no longer existing group

David Holmes david.holmes at oracle.com
Wed Mar 8 23:31:20 UTC 2017


Hi Sangheon,

On 9/03/2017 9:24 AM, sangheon wrote:
> Hi all,
>
> Could I have some reviews for this change?
>
> As current TestSmallInitialHeapWithLargePageAndNUMA.java uses old test
> group tag, changed to use the new tag.

To be clear it was not a "test group tag" but a library path that is 
wrong in the test and which has been fixed.

> The test uses the old test group tag but it is not tested on JPRT.
> Because recently jprt.properties file was changed and I was using the
> old one.
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8176403
> webrev: http://cr.openjdk.java.net/~sangheki/8176403/webrev.0

Looks fine to me.

I consider this small enough to be pushed under the trivial change rule 
- particularly as it blocks other pushes.

Thanks,
David


> Testing: JPRT (checked the test is ran and passed)
>
> Thanks,
> Sangheon


More information about the hotspot-gc-dev mailing list