RFR (S/M): 8155094: Add logging for long lasting methods found in JDK-8152948

sangheon sangheon.kim at oracle.com
Wed Mar 15 22:37:09 UTC 2017


Hi Thomas,

On 03/07/2017 12:24 AM, Thomas Schatzl wrote:
> Hi Kim,
>
> On Tue, 2017-03-07 at 01:52 -0500, Kim Barrett wrote:
>>> On Mar 6, 2017, at 8:52 AM, Thomas Schatzl <thomas.schatzl at oracle.c
>>> om> wrote:
>>>
>>> Hi,
>>>
>>> On Mon, 2017-03-06 at 14:46 +0100, Thomas Schatzl wrote:
>>>>   Hi Kim,
>>>>   
>>>>     thanks for your review.
>>> [...]
>>>
>>>
>>>    I forgot to add the links to the new webrevs:
>>>
>>> http://cr.openjdk.java.net/~tschatzl/8155094/webrev.0_to_1/
>>> (incrementa
>>> l)
>>>
>>> http://cr.openjdk.java.net/~tschatzl/8155094/webrev.1/ (full)
>>>
>>> Thanks,
>>>    Thomas
>> I take it you decided not to undo (some of) the
>> start_new_collection_set() change?
>>
>> Assuming that was intentional, looks good.
>>
> I kept these changes, that were indeed intentional. I was asking about
> your opinion about this matter - it seemed appropriate to me do this
> minor refactoring while in this code.
>
> There is some additional time to think about this as I need a second
> reviewer anyway.
webrev.1 (including minor refactoring) seems good to me.

Thanks,
Sangheon


>
> Thanks,
>    Thomas
>



More information about the hotspot-gc-dev mailing list