RFR (S/M): 8149127: Rename g1/concurrentMarkThread.* to g1/g1ConcurrentMarkThread.*

Stefan Johansson stefan.johansson at oracle.com
Fri Nov 3 11:30:51 UTC 2017


Hi Thomas,

On 2017-11-02 14:03, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for this renaming work as indicated by the
> subject?
>
> For easier review I provided three webrevs (although the "full" is not
> that hard to review), the first renaming the files, the second renaming
> the classes on top of that, and the third the complete webrev I intend
> to push.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8149127
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8149127/webrev/ (full)
> http://cr.openjdk.java.net/~tschatzl/8149127/webrev.a/ (file renaming)
> http://cr.openjdk.java.net/~tschatzl/8149127/webrev.b/ (class renaming)
Thanks for doing this cleanup Thomas.

Looks really good. Just one small thing, could you rename the getter in 
G1CollectedHeap:
1392   G1ConcurrentRefine* concurrent_g1_refine() const { return _cg1r; }

I think it would make sense to rename it to g1_concurrent_refine().

Thanks,
Stefan

> Testing:
> jprt builds
>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list