RFR(M): 8190308: Supporting heap allocation on alternative memory devices and CSR review

Thomas Schatzl thomas.schatzl at oracle.com
Fri Nov 3 14:31:17 UTC 2017


Hi,

On Fri, 2017-11-03 at 08:55 +0000, Kharbas, Kishor wrote:
> Hi Sangheon,
>  
> Thanks for the review and comments. Here is an updated webrev-
> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12
> http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12_to_11
>  
> In addition to your suggested corrections, I added code to set Linux
> core dump filter ensuring Heap is dumped correctly when this feature
> is used. This is follow-up to Jini George’s comment
> (http://openjdk.5641.n7.nabble.com/RFR-M-8171181-Supporting-heap-
> allocation-on-alternative-memory-devices-td300109.html#a300450).

Some minor nits:

 - os_posix.cpp:300: please move the else next to the brace
 - arguments.cpp:4624: please add a space between "if" and the bracket

I do not need to see a new webrev for these changes. Looks good.

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list