8191562: Missing include in gcArguments.cpp breaks minimal JVM build

Roman Kennke rkennke at redhat.com
Mon Nov 20 17:14:17 UTC 2017


Hi Martin,
no, I don't think this is necessary. We can sneak it into this change:

http://cr.openjdk.java.net/~rkennke/8191562/webrev.01/ 
<http://cr.openjdk.java.net/%7Erkennke/8191562/webrev.01/>

Is that what aix needs?

Thanks,
Roman

> Hi Roman,
>
> unfortunately, I was checking AIX too late. There's another missing include.
> We need to #include "memory/allocation.inline.hpp". Otherwise xlC doesn't find a definition for the new/delete operators like CHeapObj<F>::operator new.
>
> Do you want me to open a new bug for it?
>
> Best regards,
> Martin
>
>
> -----Original Message-----
> From: hotspot-gc-dev [mailto:hotspot-gc-dev-bounces at openjdk.java.net] On Behalf Of Roman Kennke
> Sent: Montag, 20. November 2017 11:37
> To: hotspot-gc-dev at openjdk.java.net
> Subject: RFR: 8191562: Missing include in gcArguments.cpp breaks minimal JVM build
>
> David Holmes reported build failures in minimal JVM due to missing
> include in gcArguments.cpp:
>
> https://bugs.openjdk.java.net/browse/JDK-8191562
>
> This should fix it:
>
> http://cr.openjdk.java.net/~rkennke/8191562/webrev.00/
> <http://cr.openjdk.java.net/%7Erkennke/8191562/webrev.00/>
>
> Unfortunately, the minimal JVM doesn't build at all for me (*), so I am
> posting this blindly. However, it seems fairly obvious that it's
> correct: UNSUPPORTED_OPTION is defined in arguments.hpp, including it
> should fix the build failure.
>
> Ok to go?
>
> Roman
>
> (*)
>
> /home/rkennke/src/openjdk/jdk-hs/src/hotspot/cpu/x86/c1_Runtime1_x86.cpp:
> In member function 'int StubAssembler::call_RT(Register, Register,
> address, int)':
> /home/rkennke/src/openjdk/jdk-hs/src/hotspot/cpu/x86/c1_Runtime1_x86.cpp:136:10:
> error: 'call_offset' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
>      return call_offset;
>             ^
> cc1plus: all warnings being treated as errors
>



More information about the hotspot-gc-dev mailing list