RFR (M): 8190426: Lazily initialize refinement threads with UseDynamicNumberOfGCThreads

Thomas Schatzl thomas.schatzl at oracle.com
Wed Nov 22 15:25:47 UTC 2017


Hi Sangheon,

On Tue, 2017-11-21 at 11:56 -0800, sangheon.kim wrote:
> Hi Thomas,
> 
> On 11/20/2017 10:17 AM, Thomas Schatzl wrote:
> > Hi all,
> > 
> >    Stefan Johansson found another issue: in the original code,
> > beforeactivating a thread it checked whether that thread had
> > already been activated. The changes did not do that.
> > 
> > Here's a new webrev:
> > 
> > http://cr.openjdk.java.net/~tschatzl/8190426/webrev.1_to_2//  (diff
> > )
> > http://cr.openjdk.java.net/~tschatzl/8190426/webrev.2//  (full)
> 
> webrev.2 looks good to me.
> 
> And thank you for addressing my comments on webrev.1.
> I agree we can improve lazily allocating threads with JDK-8191082:
> Unify handling of thread sets when allocating them lazily.
> 

Thanks for your review,
  Thomas



More information about the hotspot-gc-dev mailing list