RFR: 8191821: Finer granularity for GC verification

Thomas Schatzl thomas.schatzl at oracle.com
Thu Nov 30 11:54:26 UTC 2017


Hi,

On Wed, 2017-11-29 at 16:43 +0100, Stefan Johansson wrote:
> Thanks for reviewing Thomas,
> 
> Updated webrevs:
> Inc:  http://cr.openjdk.java.net/~sjohanss/8191821/01-02/
> Full: http://cr.openjdk.java.net/~sjohanss/8191821/02/
> 
> [...]
> > 

Thanks for all your changes.

Two minor issues:

- in TestVerifyGCType.java, at the end there is a typo:
s/differnt/different

- please document the return type of
GCArguments::parse_verification_type. It's non-obvious imho.

Looks good otherwise. I do not need a re-review for these two nits
above.

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list