RFR: 8191564: Refactor GC related servicability code into GC specific subclasses

mandy chung mandy.chung at oracle.com
Thu Nov 30 18:12:01 UTC 2017



On 11/30/17 6:22 AM, Roman Kennke wrote:
> Hi David,
>
> I added the tag as you proposed:
>
> Differential:
> http://cr.openjdk.java.net/~rkennke/8191564/webrev.08.diff/
> Full:
> http://cr.openjdk.java.net/~rkennke/8191564/webrev.08/
>

This looks really good.  This version looks much better than an early 
version I looked at (thanks for regenerating webrev with hg rename).

A minor comment that GCMemoryManager could take an enum to indicate the 
type of this  GC action (major vs minor).   This can be a future cleanup.

thanks
Mandy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20171130/22958f9c/attachment.html>


More information about the hotspot-gc-dev mailing list