RFR (S): 8200426: Make G1 code use _g1h members

Stefan Johansson stefan.johansson at oracle.com
Tue Apr 3 07:16:55 UTC 2018


Still good!

Stefan

On 2018-03-30 12:49, Thomas Schatzl wrote:
> Hi,
>
> On Thu, 2018-03-29 at 21:40 -0700, sangheon.kim wrote:
>> Hi Thomas,
>>
>> On 03/29/2018 11:29 AM, Thomas Schatzl wrote:
>>> Hi,
>>>
>>> On Thu, 2018-03-29 at 10:10 -0700, sangheon.kim wrote:
>>>> Hi Thomas,
>>>>
>>>> Thank you for addressing this cleanup!
>>>>
>>>> On 03/29/2018 07:19 AM, Thomas Schatzl wrote:
>>>>> Hi all,
>>>>>
>>>>>      can I have reviews for this change that tries to make the
>>>>> use of locally cached members of G1CollectedHeap* uniform by
>>>>> actually using it and renaming the members uniformly to "g1h".
>>>>>
>>>>> This change has been suggested in a recent review.
>>>>>
>>>>> There has not actually been a lot to change.
>>>>>
>>>>> CR:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8200426
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~tschatzl/8200426/webrev
>>>> Looks good.
>>>> And I found more.
>>>>
>>> I should improve my grep-fu...
>> Sometimes good IDE works better. :-)
>>
>>> Anyway, I think I fixed all of this and some more locations at
>>>
>>> http://cr.openjdk.java.net/~tschatzl/8200426/webrev.0_to_1 (diff)
>>> http://cr.openjdk.java.net/~tschatzl/8200426/webrev.1 (full)
>> Looks good, but below is not fixed.
>> I don't need a new webrev for this.
>>
>> src/hotspot/share/gc/g1/g1OopClosures.hpp:
>>     191:   G1CollectedHeap* _g1;
>>     196:     _g1(g1h),
>>
>> src/hotspot/share/gc/g1/g1OopClosures.inline.hpp:
>>     146:   HeapRegionRemSet* to_rem_set =
>> _g1->heap_region_containing(obj)->rem_set();
>>
>    I updated the webrev in place.
>
> Thanks for your review.
>
> Thanks,
>    Thomas



More information about the hotspot-gc-dev mailing list