RFR: 8200626: Restore history for g1ConcurrentMarkThread.*

Aleksey Shipilev shade at redhat.com
Wed Apr 4 09:04:01 UTC 2018


On 04/04/2018 10:59 AM, Erik Helin wrote:
>> "hg log -G -l 5" or something would be nice to see too.
> 
> Since this change involves so much hg metadata that is important, I uploaded a hg bundle:
> 
> http://cr.openjdk.java.net/~ehelin/8200626/8200626.bundle
> 
> To review the change, just:
> 
> $ # download the bundle
> $ wget http://cr.openjdk.java.net/~ehelin/8200626/8200626.bundle
> 
> $ hg incoming 8200626.bundle # list the changesets in the bundle
> $ hg pull -u 8200626.bundle # pull the changesets into your repository
> $ hg log --graph # inspect the log
> 
> $ hg diff -r be49a19be03b:0ab2411f270d # verify that merge is benign
> $ hg diff -r 8c78b974cd55 -r 0ed1370f52bb # verify my change is
>                                           # identical to Leo's

Yes, verified. Thanks!

I think it is trivial code-wise, and the risk of waiting 24 hrs opens up the opportunity to screw up
the re-merge later. Therefore, I think we should push it right away. Maybe another Reviewer should
double-check :)

Thanks,
-Aleksey


More information about the hotspot-gc-dev mailing list