RFR: JDK-8199735: Mark word updates need to use Access API

Erik Osterlund erik.osterlund at oracle.com
Wed Apr 4 20:54:24 UTC 2018


Hi Roman,

I will sponsor this for you.

/Erik

> On 4 Apr 2018, at 22:30, Roman Kennke <rkennke at redhat.com> wrote:
> 
> Ping? Should I go ahead and push it?
> 
> Thanks,
> Roman
> 
>> Hi Mikael,
>> 
>> ok. So how do we go about it?
>> - I can hold back the patch, and have somebody inside work it out
>> (adding a few #include "oops/oop.inline.hpp" shouldn't hurt even without
>> the big patch). This would have the advantage that I can submit a round
>> of testing myself
>> - I can push the patch and you Oracles guys sort it out after the fact
>> - Somebody in Oracle can take my patch and sponsor it 'the old way' and
>> amend it with the internal fixes as necessary.
>> - something else?
>> 
>> Please let me know!
>> 
>> Thanks, Roman
>> 
>> 
>>> 
>>> Yes, it’s part of the (still closed) JFR sources. Somebody at Oracle will have to help update. Sorry for the inconvenience.
>>> 
>>> Cheers,
>>> Mikael
>>> 
>>>> On Apr 3, 2018, at 5:05 PM, Roman Kennke <rkennke at redhat.com> wrote:
>>>> 
>>>> Thanks, Mikael!
>>>> 
>>>> What is edgeStore.o and how is it built? I suspect it needs an
>>>> additional #include "oops/oop.inline.hpp" but I can't find the
>>>> corresponding source?
>>>> 
>>>> Roman
>>>> 
>>>> 
>>>>> 
>>>>> src/hotspot/share/oops/oop.hpp", line 70: Error: The function oopDesc::set_mark(markOopDesc*volatile) has not had a body defined.
>>>>> src/hotspot/share/oops/oop.hpp", line 66: Error: The function oopDesc::mark() const has not had a body defined.
>>>>> 2 Error(s) detected.
>>>>> lib/CompileJvm.gmk:212: recipe for target 'build/solaris-sparcv9-debug/hotspot/variant-server/libjvm/objs/edgeStore.o' failed
>>>>> make[3]: *** [build/solaris-sparcv9-debug/hotspot/variant-server/libjvm/objs/edgeStore.o] Error 1
>>>>> 
>>>>> 
>>>>> Cheers,
>>>>> Mikael
>>>>> 
>>>>>> On Apr 3, 2018, at 4:39 PM, Roman Kennke <rkennke at redhat.com
>>>>>> <mailto:rkennke at redhat.com>> wrote:
>>>>>> 
>>>>>>> Am 03.04.2018 um 14:21 schrieb Aleksey Shipilev:
>>>>>>> On 03/26/2018 06:40 PM, Roman Kennke wrote:
>>>>>>>>>> Differential:
>>>>>>>>>> http://cr.openjdk.java.net/~rkennke/JDK-8199735/webrev.03.diff/
>>>>>>>>>> Full:
>>>>>>>>>> http://cr.openjdk.java.net/~rkennke/JDK-8199735/webrev.03/
>>>>>>> 
>>>>>>> Looks good. A bit unfortunate it has to have many changes around due
>>>>>>> to the rename, but oh well.
>>>>>>> 
>>>>>>> Thanks,
>>>>>>> -Aleksey
>>>>>>> 
>>>>>> 
>>>>>> Something seems to make Solaris/Sparc builds unhappy. Can somebody with
>>>>>> access to the test/build system check it?
>>>>>> 
>>>>>> Thanks, Roman
>>>>>> 
>>>>>> 
>>>>>> Build Details: 2018-04-03-2039378.roman.source
>>>>>> 0 Failed Tests
>>>>>> Mach5 Tasks Results Summary
>>>>>> 
>>>>>>   EXECUTED_WITH_FAILURE: 2
>>>>>>   KILLED: 0
>>>>>>   NA: 0
>>>>>>   UNABLE_TO_RUN: 4
>>>>>>   PASSED: 77
>>>>>>   FAILED: 0
>>>>>>   Build
>>>>>> 
>>>>>>       2 Not run
>>>>>>           build_jdk_solaris-solaris-sparcv9-solaris-sparcv9-build-8
>>>>>> error while building, return value: 2
>>>>>> 
>>>>>> build_jdk_solaris-solaris-sparcv9-debug-solaris-sparcv9-build-9 error
>>>>>> while building, return value: 2
>>>>>> 
>>>>>>   Test
>>>>>> 
>>>>>>       4 Not run
>>>>>> 
>>>>>> tier1-solaris-sparc-jdk_closed_test_hotspot_jtreg_tier1_common-solaris-sparcv9-70
>>>>>> Dependency task failed:
>>>>>> mach5...laris-solaris-sparcv9-solaris-sparcv9-build-8
>>>>>> 
>>>>>> tier1-solaris-sparc-jdk_closed_test_hotspot_jtreg_tier1_common-solaris-sparcv9-debug-71
>>>>>> Dependency task failed:
>>>>>> mach5...solaris-sparcv9-debug-solaris-sparcv9-build-9
>>>>>> 
>>>>>> tier1-solaris-sparc-jdk_open_test_hotspot_jtreg_tier1_common-solaris-sparcv9-68
>>>>>> Dependency task failed:
>>>>>> mach5...laris-solaris-sparcv9-solaris-sparcv9-build-8
>>>>>> 
>>>>>> tier1-solaris-sparc-jdk_open_test_hotspot_jtreg_tier1_common-solaris-sparcv9-debug-69
>>>>>> Dependency task failed:
>>>>>> mach5...solaris-sparcv9-debug-solaris-sparcv9-build-9
>>>>>> 
>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>>>> 
>>> 
>> 
>> 
> 
> 



More information about the hotspot-gc-dev mailing list