RFR: 8200169: Flatten G1Allocator class hierarchy

sangheon.kim sangheon.kim at oracle.com
Thu Apr 5 20:15:12 UTC 2018


Hi Stefan,

On 04/05/2018 05:04 AM, Stefan Johansson wrote:
> Can I please have a second review?
>
> Cheers,
> Stefan
>
> On 2018-03-26 10:27, Stefan Johansson wrote:
>> Thanks for the review Thomas,
>> Stefan
>>
>> On 2018-03-23 17:02, Thomas Schatzl wrote:
>>> Hi,
>>>
>>> On Fri, 2018-03-23 at 14:32 +0100, Stefan Johansson wrote:
>>>> Hi,
>>>>
>>>> Please review this change to remove some unnecessary class
>>>> hierarchies
>>>> in G1.
>>>>
>>>> Links
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8200169
>>>> Webrev: http://cr.openjdk.java.net/~sjohanss/8200169/00/
This looks good.

If you are interested, please update copyright year at g1Allocator.hpp 
and g1Allocator.inline.hpp.

Thanks,
Sangheon


>>>>
>>>> Summary
>>>> After the removal of several extension points and some other cleanups
>>>> in G1, there is no longer any need for the two class hierarchies in
>>>> g1Allocator.hpp. These can be flattened to only consist of two
>>>> concrete classes instead.
>>>    looks good to me.
>>>
>>> Thomas
>>>
>>



More information about the hotspot-gc-dev mailing list