RFR: 8201209: Separate out CMS specific functions into CMSCardTable
erik.osterlund at oracle.com
Fri Apr 6 06:59:00 UTC 2018
Nice! This one has been at the back of my head for a while. This looks good.
One thing though. I wonder if the CMSCardTable constructor should take that argument whether the table is scanned concurrently or not (when pre-cleaning is enabled). Perhaps that logic could be in the constructor of CMSCardTable instead. I tend to think it belongs in the constructor. It is not a strong preference though, so I will leave it as your call, and will not need another webrev.
> On 5 Apr 2018, at 22:42, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
> Hi all,
> Please review this patch to move CMS specific CardTableRS code into a new CMSCardTable class.
> Erik Ö suggested that I named the class CMSCardTable instead of CMSCardTableRS, because CardTableRS would probably renamed in the future.
> This patch makes it easier to conditionally compile out CMS in:
> https://bugs.openjdk.java.net/browse/JDK-8200729 - Conditional compilation of GCs
More information about the hotspot-gc-dev