RFR: 8201217: Split specialized_oop_closures.hpp into GC specific files

Erik Österlund erik.osterlund at oracle.com
Mon Apr 9 09:40:25 UTC 2018


Hi StefanK,

I'm guessing the SPECIALIZED_OOP_OOP_ITERATE_CLOSURES_1 vs 
SPECIALIZED_OOP_OOP_ITERATE_CLOSURES_2 distinction can be removed 
assuming that the MSVC problems that motivated their introduction is 
gone today. Same goes for how 
PromotionInfo::promoted_oops_iterate##nv_suffix is generated with 
SPECIALIZED_SINCE_SAVE_MARKS_CLOSURES_YOUNG as a workaround for the same 
problem as described in a comment in promotionInfo.cpp. But that seems 
like going beyond the intended scope of this change.

Looks good.

Thanks,
/Erik

On 2018-04-06 00:24, Stefan Karlsson wrote:
> Hi all,
>
> Please review this patch to split up the specialized_oop_closures.hpp 
> file into GC specific files.
>
> http://cr.openjdk.java.net/~stefank/8201217/webrev.01
> https://bugs.openjdk.java.net/browse/JDK-8201217
>
> Thanks,
> StefanK



More information about the hotspot-gc-dev mailing list