RFR: 8201209: Separate out CMS specific functions into CMSCardTable

Stefan Karlsson stefan.karlsson at oracle.com
Mon Apr 9 12:18:15 UTC 2018


Thanks, StefanJ.

StefanK

On 2018-04-09 10:46, Stefan Johansson wrote:
> Hi Stefan,
> 
> On 2018-04-06 10:59, Stefan Karlsson wrote:
>> On 2018-04-06 08:59, Erik Osterlund wrote:
>>> Hi Stefan,
>>>
>>> Nice! This one has been at the back of my head for a while. This 
>>> looks good.
>>
>> Thanks!
>>
>>>
>>> One thing though. I wonder if the CMSCardTable constructor should 
>>> take that argument whether the table is scanned concurrently or not 
>>> (when pre-cleaning is enabled). Perhaps that logic could be in the 
>>> constructor of CMSCardTable instead. I tend to think it belongs in 
>>> the constructor. It is not a strong preference though, so I will 
>>> leave it as your call, and will not need another webrev.
>>>
>>
>> Yes, this sounds good to me. Updated webrevs:
>>
>> http://cr.openjdk.java.net/~stefank/8201209/webrev.02.delta
>> http://cr.openjdk.java.net/~stefank/8201209/webrev.02
> Looks good,
> StefanJ
> 
>>
>> StefanK
>>
>>> Thanks,
>>> /Erik
>>>
>>>> On 5 Apr 2018, at 22:42, Stefan Karlsson 
>>>> <stefan.karlsson at oracle.com> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> Please review this patch to move CMS specific CardTableRS code into 
>>>> a new CMSCardTable class.
>>>>
>>>>   http://cr.openjdk.java.net/~stefank/8201209/webrev.01/
>>>>   https://bugs.openjdk.java.net/browse/JDK-8201209
>>>>
>>>> Erik Ö suggested that I named the class CMSCardTable instead of 
>>>> CMSCardTableRS, because CardTableRS would probably renamed in the 
>>>> future.
>>>>
>>>> This patch makes it easier to conditionally compile out CMS in:
>>>>   https://bugs.openjdk.java.net/browse/JDK-8200729 - Conditional 
>>>> compilation of GCs
>>>>
>>>> Thanks,
>>>> StefanK
>>>


More information about the hotspot-gc-dev mailing list