RFR: 8201217: Split specialized_oop_closures.hpp into GC specific files

Stefan Karlsson stefan.karlsson at oracle.com
Mon Apr 9 12:20:32 UTC 2018


On 2018-04-09 11:40, Erik Österlund wrote:
> Hi StefanK,
> 
> I'm guessing the SPECIALIZED_OOP_OOP_ITERATE_CLOSURES_1 vs 
> SPECIALIZED_OOP_OOP_ITERATE_CLOSURES_2 distinction can be removed 
> assuming that the MSVC problems that motivated their introduction is 
> gone today. Same goes for how 
> PromotionInfo::promoted_oops_iterate##nv_suffix is generated with 
> SPECIALIZED_SINCE_SAVE_MARKS_CLOSURES_YOUNG as a workaround for the same 
> problem as described in a comment in promotionInfo.cpp. But that seems 
> like going beyond the intended scope of this change.

Yes, I agree. We should clean that up. I'll take care of this in a 
separate RFE.

> 
> Looks good.

Thanks.

StefanK

> 
> Thanks,
> /Erik
> 
> On 2018-04-06 00:24, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review this patch to split up the specialized_oop_closures.hpp 
>> file into GC specific files.
>>
>> http://cr.openjdk.java.net/~stefank/8201217/webrev.01
>> https://bugs.openjdk.java.net/browse/JDK-8201217
>>
>> Thanks,
>> StefanK
> 


More information about the hotspot-gc-dev mailing list