RFR: 8201362: Remove CollectedHeap::barrier_set()

Roman Kennke rkennke at redhat.com
Thu Apr 12 08:48:30 UTC 2018


Am 12.04.2018 um 10:31 schrieb Aleksey Shipilev:
> On 04/12/2018 10:26 AM, Per Liden wrote:
>> This patch removes the redundant CollectedHeap::_barrier_set and the
>> setter/getter. Throughout the code, we currently have a mix of calls to BarrierSet::barrier_set()
>> and Universe::heap()->barrier_set(). This patch unifies all that to always use
>> BarrierSet::barrier_set().
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8201362
>> Webrev: http://cr.openjdk.java.net/~pliden/8201362/webrev.0
> 
> Yes, please. This looks trivial.
> 
> (If we are pushing this today, it is better to do this early, so we would be able to catch up with
> build errors before jdk/hs closing today)
> 

I wouldn't say it's trivial ;-) But the change looks good to me too and
is welcome. Thank you!

Roman


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20180412/33b5b7d0/signature-0001.asc>


More information about the hotspot-gc-dev mailing list