RFR: 8201362: Remove CollectedHeap::barrier_set()

Thomas Stüfe thomas.stuefe at gmail.com
Thu Apr 12 09:02:28 UTC 2018


Hi Per,

took a quick stab in the dark at
src/hotspot/cpu/s390/templateTable_s390.cpp and it seems to miss, at
first glance, barrierSet.hpp.

Since ppc, s390 and aarch64 are already broken, could we please delay
pushing this until 8201475 is resolved? An hour or so?

Thanks, Thomas

On Thu, Apr 12, 2018 at 10:48 AM, Roman Kennke <rkennke at redhat.com> wrote:
> Am 12.04.2018 um 10:31 schrieb Aleksey Shipilev:
>> On 04/12/2018 10:26 AM, Per Liden wrote:
>>> This patch removes the redundant CollectedHeap::_barrier_set and the
>>> setter/getter. Throughout the code, we currently have a mix of calls to BarrierSet::barrier_set()
>>> and Universe::heap()->barrier_set(). This patch unifies all that to always use
>>> BarrierSet::barrier_set().
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8201362
>>> Webrev: http://cr.openjdk.java.net/~pliden/8201362/webrev.0
>>
>> Yes, please. This looks trivial.
>>
>> (If we are pushing this today, it is better to do this early, so we would be able to catch up with
>> build errors before jdk/hs closing today)
>>
>
> I wouldn't say it's trivial ;-) But the change looks good to me too and
> is welcome. Thank you!
>
> Roman
>
>


More information about the hotspot-gc-dev mailing list