RFR: JDK-8201442: objArrayOopDesc::atomic_compare_exchange_oop() must use obj+offset in HeapAccess call

Erik Österlund erik.osterlund at oracle.com
Thu Apr 12 09:11:08 UTC 2018


Hi Roman,

Looks good. Would be great to stick that IN_HEAP_ARRAY decorator in the 
mix as well, so that when we decide runtime code should use precise 
marking for arrays, we catch this case. I don't need another webrev for 
that.

Thanks,
/Erik

On 2018-04-11 21:49, Roman Kennke wrote:
> Please review the following little change.
>
>
> objArrayOopDesc::atomic_compare_exchange_oop() currently computes and
> uses a raw pointer to pass to HeapAccess::oop_atomic_cmpxchg(). It
> should use the object+offset variant because it's accessing the heap and
> GC might need to resolve the target object (e.g. Shenandoah).
>
> http://cr.openjdk.java.net/~rkennke/JDK-8201442/webrev.01/
>
> Testing: hotspot-tier1
>
>
> Roman
>



More information about the hotspot-gc-dev mailing list