RFR: 8201362: Remove CollectedHeap::barrier_set()

Per Liden per.liden at oracle.com
Thu Apr 12 09:11:23 UTC 2018


On 04/12/2018 10:48 AM, Roman Kennke wrote:
> Am 12.04.2018 um 10:31 schrieb Aleksey Shipilev:
>> On 04/12/2018 10:26 AM, Per Liden wrote:
>>> This patch removes the redundant CollectedHeap::_barrier_set and the
>>> setter/getter. Throughout the code, we currently have a mix of calls to BarrierSet::barrier_set()
>>> and Universe::heap()->barrier_set(). This patch unifies all that to always use
>>> BarrierSet::barrier_set().
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8201362
>>> Webrev: http://cr.openjdk.java.net/~pliden/8201362/webrev.0
>>
>> Yes, please. This looks trivial.
>>
>> (If we are pushing this today, it is better to do this early, so we would be able to catch up with
>> build errors before jdk/hs closing today)
>>
> 
> I wouldn't say it's trivial ;-) But the change looks good to me too and
> is welcome. Thank you!

Thanks for reviewing, Aleksey and Roman!

I wouldn't say this is trivial either ;) But since I have two reviews 
now, I agree it's better to push this sooner rather than later, given 
that jdk/hs will close.

It's currently running in mach5, I'll push as soon as I see that 
everything looks green.

/Per

> 
> Roman
> 
> 


More information about the hotspot-gc-dev mailing list