RFR: 8201362: Remove CollectedHeap::barrier_set()

Per Liden per.liden at oracle.com
Thu Apr 12 10:05:51 UTC 2018


Thanks for verifying, Thomas!

/Per

On 04/12/2018 11:51 AM, Thomas Stüfe wrote:
> Hi Per,
> 
> I did build on AIX and linux s390 with your patch, builds are okay.
> Thanks for waiting!
> 
> ..Thomas
> 
> On Thu, Apr 12, 2018 at 11:17 AM, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
>> Sure, give me a minute...
>>
>> ..Thomas
>>
>> On Thu, Apr 12, 2018 at 11:17 AM, Per Liden <per.liden at oracle.com> wrote:
>>> Ok, thanks Thomas!
>>>
>>> Do you want to double check that 8201362 doesn't break more stuff before I
>>> push it, or are we good to go?
>>>
>>> /Per
>>>
>>>
>>> On 04/12/2018 11:13 AM, Thomas Stüfe wrote:
>>>>
>>>> I pushed 8201475, all good now. Thanks.
>>>>
>>>> On Thu, Apr 12, 2018 at 11:02 AM, Thomas Stüfe <thomas.stuefe at gmail.com>
>>>> wrote:
>>>>>
>>>>> Hi Per,
>>>>>
>>>>> took a quick stab in the dark at
>>>>> src/hotspot/cpu/s390/templateTable_s390.cpp and it seems to miss, at
>>>>> first glance, barrierSet.hpp.
>>>>>
>>>>> Since ppc, s390 and aarch64 are already broken, could we please delay
>>>>> pushing this until 8201475 is resolved? An hour or so?
>>>>>
>>>>> Thanks, Thomas
>>>>>
>>>>> On Thu, Apr 12, 2018 at 10:48 AM, Roman Kennke <rkennke at redhat.com>
>>>>> wrote:
>>>>>>
>>>>>> Am 12.04.2018 um 10:31 schrieb Aleksey Shipilev:
>>>>>>>
>>>>>>> On 04/12/2018 10:26 AM, Per Liden wrote:
>>>>>>>>
>>>>>>>> This patch removes the redundant CollectedHeap::_barrier_set and the
>>>>>>>> setter/getter. Throughout the code, we currently have a mix of calls
>>>>>>>> to BarrierSet::barrier_set()
>>>>>>>> and Universe::heap()->barrier_set(). This patch unifies all that to
>>>>>>>> always use
>>>>>>>> BarrierSet::barrier_set().
>>>>>>>>
>>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8201362
>>>>>>>> Webrev: http://cr.openjdk.java.net/~pliden/8201362/webrev.0
>>>>>>>
>>>>>>>
>>>>>>> Yes, please. This looks trivial.
>>>>>>>
>>>>>>> (If we are pushing this today, it is better to do this early, so we
>>>>>>> would be able to catch up with
>>>>>>> build errors before jdk/hs closing today)
>>>>>>>
>>>>>>
>>>>>> I wouldn't say it's trivial ;-) But the change looks good to me too and
>>>>>> is welcome. Thank you!
>>>>>>
>>>>>> Roman
>>>>>>
>>>>>>
>>>


More information about the hotspot-gc-dev mailing list