RFR: JDK-8201442: objArrayOopDesc::atomic_compare_exchange_oop() must use obj+offset in HeapAccess call

Roman Kennke rkennke at redhat.com
Thu Apr 12 10:23:17 UTC 2018


Thanks Erik & Aleksey for reviewing!

I just submitted the change for testing.

I do need to wait 24h from posting RFR, do I? That means it's gonna miss
the integration and need to wait till next week. Or do you think it's
safe to go ahead and push it, given that submit repo comes back green?

Thanks, Roman

> Looks good. Would be great to stick that IN_HEAP_ARRAY decorator in the
> mix as well, so that when we decide runtime code should use precise
> marking for arrays, we catch this case. I don't need another webrev for
> that.
> 
> Thanks,
> /Erik
> 
> On 2018-04-11 21:49, Roman Kennke wrote:
>> Please review the following little change.
>>
>>
>> objArrayOopDesc::atomic_compare_exchange_oop() currently computes and
>> uses a raw pointer to pass to HeapAccess::oop_atomic_cmpxchg(). It
>> should use the object+offset variant because it's accessing the heap and
>> GC might need to resolve the target object (e.g. Shenandoah).
>>
>> http://cr.openjdk.java.net/~rkennke/JDK-8201442/webrev.01/
>>
>> Testing: hotspot-tier1
>>
>>
>> Roman
>>
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20180412/51c864e2/signature.asc>


More information about the hotspot-gc-dev mailing list