RFR (S): 8201596: java.lang.ref.Reference processing total time logging broken

Kim Barrett kim.barrett at oracle.com
Mon Apr 16 18:43:50 UTC 2018


> On Apr 16, 2018, at 11:28 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi all,
> 
>  can I have reviews for this change that fixes the output for
> "Reference Processing" and adds "Weak Processing" like the other
> collectors have?
> 
> For some time now the "Reference Processing" entry showed the time for
> "Weak Processing", i.e. processing of VM internal weak references, not
> j.l.ref.References processing.
> 
> This is really confusing because if you add gc+phase+ref logging you
> typically get an overall shorter "Reference Processing" time than the
> sub-phases take.
> 
> Also the "Other" time is really high sometimes.
> 
> I do not think it had other impact than logging though.
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8201596
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8201596/webrev/
> Testing:
> test case, local testing, local compilation
> 
> Thanks,
>  Thomas

Looks good.



More information about the hotspot-gc-dev mailing list