RFR (S): 8201596: java.lang.ref.Reference processing total time logging broken

Thomas Schatzl thomas.schatzl at oracle.com
Wed Apr 18 07:19:50 UTC 2018


Hi Sangheon, Kim,

On Mon, 2018-04-16 at 11:48 -0700, sangheon.kim wrote:
> Hi Thomas,
> 
> On 04/16/2018 08:28 AM, Thomas Schatzl wrote:
> > Hi all,
> > 
> >    can I have reviews for this change that fixes the output for
> > "Reference Processing" and adds "Weak Processing" like the other
> > collectors have?
> > 
> > For some time now the "Reference Processing" entry showed the time
> > for "Weak Processing", i.e. processing of VM internal weak
> > references, not j.l.ref.References processing.
> > 
> > This is really confusing because if you add gc+phase+ref logging
> > you typically get an overall shorter "Reference Processing" time
> > than the sub-phases take.
> > 
> > Also the "Other" time is really high sometimes.
> > 
> > I do not think it had other impact than logging though.
> > 
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8201596
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8201596/webrev/
> 
> Looks good.
> 

  thanks for your reviews.

Thomas



More information about the hotspot-gc-dev mailing list